[TEST] Wait for no pending operations on the index shard #118244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This fixes testRetryPointInTime which on teardown is looking to assert that the operations in the translog and in the lucene index are the same. Previously we didn't wait for the translog operations to be applied. This changes `assertConsistentHistoryInLuceneIndex` to wait for the pending operations in the translog to be applied.
andreidan added >test 
elasticsearchmachine added the Team:Search Foundations 
| Pinging @elastic/es-search-foundations (Team:Search Foundations) |
| @elasticmachine update branch |
original-brownbear approved these changes Dec 9, 2024
andreidan added auto-merge-without-approval 💔 Backport failed
You can use sqren/backport to manually backport by running |
andreidan added a commit to andreidan/elasticsearch that referenced this pull request Dec 9, 2024
) This fixes testRetryPointInTime which on teardown is looking to assert that the operations in the translog and in the lucene index are the same. Previously we didn't wait for the translog operations to be applied. This changes `assertConsistentHistoryInLuceneIndex` to wait for the pending operations in the translog to be applied. Fixes elastic#117116 (cherry picked from commit b4e852a) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Dec 9, 2024
…118258) This fixes testRetryPointInTime which on teardown is looking to assert that the operations in the translog and in the lucene index are the same. Previously we didn't wait for the translog operations to be applied. This changes `assertConsistentHistoryInLuceneIndex` to wait for the pending operations in the translog to be applied. Fixes #117116 (cherry picked from commit b4e852a) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
This was referenced Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes testRetryPointInTime which on teardown is looking to assert that the operations in the translog and in the lucene index are the same.
Previously we didn't wait for the translog operations to be applied. This changes
assertConsistentHistoryInLuceneIndexto wait for the pending operations in the translog to be applied.Fixes #117116