Skip to content

Conversation

drempapis
Copy link
Contributor

This test has been failing due to #113081, which deleted the incoming search validation on the data node for bwc.

In this work, #105150, validation has been moved to the coordinate nodes. The following is a matrix of the validation Exception messages of the SearchService moving to SearchRequest, including a test creation checking.

SearchService:validateSearchSource SearchRequest:validate SearchRequestTest::testValidate	"disabling [track_total_hits] is not allowed in a scroll context. Yes yes	`search_after` cannot be used in a scroll context. yes yes	`from` parameter must be set to 0 when `search_after` is used. yes yes	cannot use `collapse` in a scroll context yes yes	cannot use `collapse` in conjunction with `rescore` yes yes	[slice] can only be used with [scroll] or [point-in-time] requests yes yes	[stored_fields] cannot be disabled if [_source] is requested yes yes	[stored_fields] cannot be disabled when using the [fields] option" yes yes 
@drempapis drempapis requested a review from javanna December 4, 2024 08:44
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 labels Dec 4, 2024
@drempapis drempapis changed the title Fix/search service tests.test parse source validation failure SearchServiceTests.testParseSourceValidation failure Dec 4, 2024
@drempapis drempapis self-assigned this Dec 4, 2024
@drempapis drempapis added >bug Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations and removed needs:triage Requires assignment of a team area label labels Dec 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine
Copy link
Collaborator

Hi @drempapis, I've created a changelog YAML for you.

…e' of github.com:drempapis/elasticsearch into fix/SearchServiceTests.testParseSourceValidation_failure
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

);
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you can delete the assertCreateContextValidation method too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@javanna
Copy link
Member

javanna commented Dec 5, 2024

Don't forget to close #115936 once this gets merged ;)

@drempapis drempapis merged commit 949816f into elastic:main Dec 5, 2024
16 checks passed
@drempapis drempapis deleted the fix/SearchServiceTests.testParseSourceValidation_failure branch December 5, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>bug :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.0.0

3 participants