- Notifications
You must be signed in to change notification settings - Fork 25.5k
Remove RestApiVersion#V_7 references for 9.0.0 #117572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
drempapis merged 29 commits into elastic:main from drempapis:refactoring/remove_rest_api_version_7_0_from_search Dec 3, 2024
Merged
Remove RestApiVersion#V_7 references for 9.0.0 #117572
drempapis merged 29 commits into elastic:main from drempapis:refactoring/remove_rest_api_version_7_0_from_search Dec 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… github.com:drempapis/elasticsearch into refactoring/remove_rest_api_version_7_0_from_search
… github.com:drempapis/elasticsearch into refactoring/remove_rest_api_version_7_0_from_search
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna reviewed Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, thanks for taking this on!
server/src/main/java/org/elasticsearch/action/termvectors/TermVectorsRequest.java Show resolved Hide resolved
server/src/main/java/org/elasticsearch/action/search/MultiSearchRequest.java Show resolved Hide resolved
server/src/main/java/org/elasticsearch/index/query/CommonTermsQueryBuilder.java Show resolved Hide resolved
javanna approved these changes Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>refactoring :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v9.0.0
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This work addresses and removes references to
org elastic search.core.RestApiVersion#V_7
from the search-related code.JIRA reference