Adding deprecation warning for data_frame_transforms roles #117521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dan-rubinstein added >non-issue :ml 
elasticsearchmachine added the external-contributor dan-rubinstein removed the external-contributor dan-rubinstein added the auto-backport 
| @elasticmachine merge upstream |
| Pinging @elastic/ml-core (Team:ML) |
jonathan-buttner approved these changes Dec 9, 2024
💚 Backport successful
|
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Dec 9, 2024
…17521) * Adding deprecation warning for data_frame_transforms roles * Updating deprecation warning URL --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue - https://github.com/elastic/ml-team/issues/1389
Description
The
data_frame_transforms_useranddata_frame_transforms_adminroles have been marked as deprected for some time now. This change adds a critical deprecation warning that will block users from migrating to 9.0 until they update any transforms using these roles to instead use the equivalenttransforms_userandtransforms_adminroles. The process to do this is outlined in the documentation added in this PR. This documentation is currently not published and the location is not finalized. As such, the deprecation warning currently has an elastic URL that we can update once the documentation is published. This PR does not need to be blocked on the documentation change as we can dynamically change what it points to through the elastic links UI without need for a follow-up code review.Testing