ESQL: Refactor named writeable entries for expressions and plans #117029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Move writable declarations outside the core classes to avoid errors (such as subClass.getNamedWritable()) and centralize them in a top package class for better management.
alex-spies added >refactoring auto-backport 
elasticsearchmachine added the Team:Analytics 
Collaborator
| Pinging @elastic/es-analytical-engine (Team:Analytics) |
Make all touched serialization code the same as in the initial PR, except for the fact that LookupJoin/LookupJoinExec are missing.
alex-spies commented Nov 19, 2024
Contributor Author
alex-spies left a comment
alex-spies left a comment There was a problem hiding this comment.
Ok, I self-reviewed as the original refactor is from Costin.
This looks good to me. If the tests pass nicely, feel free to merge this in my absence @costin !
costin approved these changes Nov 19, 2024
Member
costin left a comment
costin left a comment There was a problem hiding this comment.
LGTM - thanks for chasing this!
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
costin added a commit to costin/elasticsearch that referenced this pull request Nov 19, 2024
…stic#117029) Move writable declarations outside the core classes to avoid errors (such as subClass.getNamedWritable()) and centralize them in a top package class for better management. Make all touched serialization code the same as in the initial PR, except for the fact that LookupJoin/LookupJoinExec are missing. Co-authored-by: Costin Leau <costin.leau@gmail.com> (cherry picked from commit 0b74492)
costin added a commit that referenced this pull request Nov 20, 2024
…7029) (#117101) Move writable declarations outside the core classes to avoid errors (such as subClass.getNamedWritable()) and centralize them in a top package class for better management. Make all touched serialization code the same as in the initial PR, except for the fact that LookupJoin/LookupJoinExec are missing. (cherry picked from commit 0b74492)
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Nov 20, 2024
…stic#117029) Move writable declarations outside the core classes to avoid errors (such as subClass.getNamedWritable()) and centralize them in a top package class for better management. Make all touched serialization code the same as in the initial PR, except for the fact that LookupJoin/LookupJoinExec are missing. Co-authored-by: Costin Leau <costin.leau@gmail.com>
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
…stic#117029) Move writable declarations outside the core classes to avoid errors (such as subClass.getNamedWritable()) and centralize them in a top package class for better management. Make all touched serialization code the same as in the initial PR, except for the fact that LookupJoin/LookupJoinExec are missing. Co-authored-by: Costin Leau <costin.leau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cherry-picked out of #116515 to keep the changes more contained and be able to backport this serialization refactor to 8.x
Move writable declarations outside the core classes to avoid errors (such as subClass.getNamedWritable()) and centralize them in a top package class for better management.