- Notifications
You must be signed in to change notification settings - Fork 25.5k
Add LogsDB option to route on sort fields #116687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LogsDB option to route on sort fields #116687
Conversation
Hi @kkrik-es, I've created a changelog YAML for you. |
…nto logsdb/route-on-sort-fields-3
EDIT: ignore this, more results below. results.txt
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
There was an issue with the run above, there were many indexing errors due to missing sort field values. Updated results (sortin on
Smaller but still sizable wins, esp on indexing time. |
# Conflicts: # server/src/main/java/org/elasticsearch/cluster/routing/IndexRouting.java
…sdb/LogsdbIndexModeSettingsProvider.java Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com>
…nto logsdb/route-on-sort-fields-3
…nto logsdb/route-on-sort-fields-3
…nto logsdb/route-on-sort-fields-3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
* Add LogsDB option to route on sort fields * fix encoding * Update docs/changelog/116687.yaml * tests * tests * tests * fix mode * tests * tests * tests * add test * fix test * sync * updates from review * test fixes * test fixes * test fixes * Move logic to SyntheticSourceIndexSettingsProvider * fix test * sync * merge, no fallback * comments * fix test * address comments * address comments * address comments * Update x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProvider.java Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com> * [CI] Auto commit changes from spotless * update tests * [CI] Auto commit changes from spotless * update tests * fix rest compat tests --------- Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit d80cbdd) # Conflicts: # rest-api-spec/build.gradle # server/src/main/java/org/elasticsearch/common/TimeBasedKOrderedUUIDGenerator.java
* Add LogsDB option to route on sort fields (#116687) * Add LogsDB option to route on sort fields * fix encoding * Update docs/changelog/116687.yaml * tests * tests * tests * fix mode * tests * tests * tests * add test * fix test * sync * updates from review * test fixes * test fixes * test fixes * Move logic to SyntheticSourceIndexSettingsProvider * fix test * sync * merge, no fallback * comments * fix test * address comments * address comments * address comments * Update x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/LogsdbIndexModeSettingsProvider.java Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com> * [CI] Auto commit changes from spotless * update tests * [CI] Auto commit changes from spotless * update tests * fix rest compat tests --------- Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit d80cbdd) # Conflicts: # rest-api-spec/build.gradle # server/src/main/java/org/elasticsearch/common/TimeBasedKOrderedUUIDGenerator.java * Update LogsIndexingIT.java
This is a storage optimization, improving codec efficiency. It requires configuring more than one sort fields (excluding
@timestamp
) to reduce the likelihood for hotspots in shard routing.Related to #109334