Skip to content

Synonyms test fix - number of shards #116224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2024
Merged

Synonyms test fix - number of shards #116224

merged 4 commits into from
Nov 6, 2024

Conversation

carlosdelest
Copy link
Member

@carlosdelest carlosdelest commented Nov 5, 2024 •
edited
Loading

Some synonyms tests were failing on serverless because the number of replicas can't be established there.

Changed tests so replicas are not established, and change checks to not depend on number of replicas directly.
@elasticsearchmachine elasticsearchmachine added v9.0.0 needs:triage Requires assignment of a team area label labels Nov 5, 2024
@carlosdelest carlosdelest added >test Issues or PRs that are addressing/adding tests :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed needs:triage Requires assignment of a team area label labels Nov 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)
@carlosdelest carlosdelest changed the title Synonyms test fixFix/synonyms fix 541 Synonyms test fix - number of shards Nov 5, 2024
@carlosdelest carlosdelest marked this pull request as draft November 5, 2024 08:17
@carlosdelest carlosdelest marked this pull request as ready for review November 5, 2024 09:20
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Nov 5, 2024
kingherc
kingherc reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with respect to number of replicas. But i'll better let a Search member approve.
benwtrent
benwtrent approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@carlosdelest carlosdelest merged commit e594072 into elastic:main Nov 6, 2024
17 checks passed
@carlosdelest carlosdelest mentioned this pull request Nov 11, 2024
Merged
carlosdelest added a commit to carlosdelest/elasticsearch that referenced this pull request Nov 11, 2024
@carlosdelest
Synonyms test fix - update number of shards (elastic#116224)
9c7dbb6 
(cherry picked from commit e594072)
carlosdelest added a commit that referenced this pull request Nov 11, 2024
@carlosdelest
Synonyms test fix - update number of shards (#116224) (#116609)
1c299fd 
(cherry picked from commit e594072)
@carlosdelest carlosdelest mentioned this pull request Nov 11, 2024
Merged
jozala pushed a commit that referenced this pull request Nov 13, 2024
@carlosdelest @jozala
Synonyms test fix - update number of shards (#116224)
5c7a1d0
@carlosdelest carlosdelest mentioned this pull request Nov 25, 2024
Merged
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@carlosdelest @alexey-ivanov-es
Synonyms test fix - update number of shards (elastic#116224)
6191661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Relevance/Analysis How text is split into tokens serverless-linked Added by automation, don't add manually Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.0.0

4 participants

@carlosdelest @elasticsearchmachine @benwtrent @kingherc