Remove deprecated local parameter from alias APIs #115393
Conversation
This removes the `local` attribute from the `GET /_alias`, `HEAD /_alias`, and `GET /_cat/aliases` APIs. This option became a no-op and was deprecated in 8.12 by elastic#101815.
PeteGillinElastic added :Data Management/Indices APIs 
| Hi @PeteGillinElastic, I've created a changelog YAML for you. Note that since this PR is labelled |
PeteGillinElastic added >breaking and removed :Data Management/CAT APIs | Hi @PeteGillinElastic, I've updated the changelog YAML for you. Note that since this PR is labelled |
PeteGillinElastic changed the title 
| @elasticmachine update branch |
| merge conflict between base and head |
…ocal-from-get-aliases
elasticsearchmachine added the Team:Data Management | Pinging @elastic/es-data-management (Team:Data Management) |
| task.skipTest("indices.sort/10_basic/Index Sort", "warning does not exist for compatibility") | ||
| task.skipTest("search/330_fetch_fields/Test search rewrite", "warning does not exist for compatibility") | ||
| task.skipTest("indices.create/21_synthetic_source_stored/object param - nested object with stored array", "temporary until backported") | ||
| task.skipTest("cat.aliases/10_basic/Deprecated local parameter", "CAT APIs not covered by compatibility policy") |
There was a problem hiding this comment.
N.B. Even if we did implement BWC in the code, we'd still have to skip this test because the test framework does not send the compatible-with headers for CAT APIs.
PeteGillinElastic deleted the remove-deprecated-local-from-get-aliases branch 
This removes the `local` parameter from the `GET /_alias`, `HEAD /_alias`, and `GET /_cat/aliases` APIs. This option became a no-op and was deprecated in 8.12 by elastic#101815. We continue to accept the parameter (deprecated, with no other effect) in v8 compatibility mode for `GET /_alias` and `HEAD /_alias`. We don't do this for `GET /_cat/aliases` where the [compatibility policy does not apply](https://github.com/elastic/elasticsearch/blob/main/REST_API_COMPATIBILITY.md#when-not-to-apply).
This removes the `local` parameter from the `GET /_alias`, `HEAD /_alias`, and `GET /_cat/aliases` APIs. This option became a no-op and was deprecated in 8.12 by elastic#101815. We continue to accept the parameter (deprecated, with no other effect) in v8 compatibility mode for `GET /_alias` and `HEAD /_alias`. We don't do this for `GET /_cat/aliases` where the [compatibility policy does not apply](https://github.com/elastic/elasticsearch/blob/main/REST_API_COMPATIBILITY.md#when-not-to-apply).
| @PeteGillinElastic is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes] |
| I think this depends on the policy for the serverless changelog. This property was deprecated and ignored since 8.0.0, so nobody should have been using it in serverless. I don't know whether this should be mentioned or not. Also, this change was made in October, before serverless GA. |
5 participants
This removes the
localparameter from theGET /_alias,HEAD /_alias, andGET /_cat/aliasesAPIs. This option became a no-op and was deprecated in 8.12 by #101815.We continue to accept the parameter (deprecated, with no other effect) in v8 compatibility mode for
GET /_aliasandHEAD /_alias. We don't do this forGET /_cat/aliaseswhere the compatibility policy does not apply.