Skip to content

Adding endpoint creation validation for all task types to remaining services #115020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dan-rubinstein merged 8 commits into from
Nov 25, 2024
Merged

Adding endpoint creation validation for all task types to remaining services #115020

dan-rubinstein merged 8 commits into from
Nov 25, 2024

Conversation

@dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Oct 17, 2024 •
edited
Loading

Description

This change introduces:

  • Adds new validation logic for creating endpoints in the Alibaba, AmazonBedrock, Anthropic, AzureOpenAi, Cohere, GoogleVertexAI, and IBMWatson services.
    • For text embedding endpoints the logic will make a validation call, update the model's dimensions to match the returned embedding size, and set the default similarity measure value when necessary.
    • For non text embedding models, the validation will ensure that a non-null response is returned when calling the service.

Testing

  • Ran unit tests and ensured that all succeed
  • Validated that trying to create valid endpoints for all of the services above makes a validation call and updates the model when necessary.
  • Validated that trying to create an invalid endpoint for all of the services above makes a validation call and fails and the endpoint is not created.
@elasticsearchmachine elasticsearchmachine added v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 17, 2024
@dan-rubinstein dan-rubinstein added v8.17.0 :ml Machine learning Team:ML Meta label for the ML team labels Nov 6, 2024
@dan-rubinstein dan-rubinstein marked this pull request as ready for review November 6, 2024 21:14
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 6, 2024

Pinging @elastic/ml-core (Team:ML)
@dan-rubinstein dan-rubinstein added >enhancement and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 7, 2024
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 7, 2024

Hi @dan-rubinstein, I've created a changelog YAML for you.
davidkyle
davidkyle approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@dan-rubinstein
Copy link
Member Author

dan-rubinstein commented Nov 18, 2024

@elasticmachine merge upstream
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 18, 2024

There are no new commits on the base branch.
davidkyle
davidkyle approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@dan-rubinstein
Copy link
Member Author

dan-rubinstein commented Nov 25, 2024

@elasticmachine merge upstream
@dan-rubinstein dan-rubinstein added auto-backport Automatically create backport pull requests when merged v8.18.0 labels Nov 25, 2024
@dan-rubinstein dan-rubinstein merged commit 9981a1d into elastic:main Nov 25, 2024
16 checks passed
@dan-rubinstein dan-rubinstein mentioned this pull request Nov 25, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Nov 25, 2024

💚 Backport successful

Status Branch Result
✅ 8.x
dan-rubinstein added a commit to dan-rubinstein/elasticsearch that referenced this pull request Nov 25, 2024
@dan-rubinstein @elasticmachine
Adding endpoint creation validation for all task types to remaining s…
d13b23d 
…ervices (elastic#115020) * Adding endpoint creation validation for all task types to remaining services * Update Cohere IT tests for rerank validation * Adding missing import * Update docs/changelog/115020.yaml * Fixing GoogleVertex tests after merge from upstream --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine pushed a commit that referenced this pull request Nov 25, 2024
@dan-rubinstein @elasticmachine
Adding endpoint creation validation for all task types to remaining s…
f5295ab 
…ervices (#115020) (#117490) * Adding endpoint creation validation for all task types to remaining services * Update Cohere IT tests for rerank validation * Adding missing import * Update docs/changelog/115020.yaml * Fixing GoogleVertex tests after merge from upstream --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@dan-rubinstein @elasticmachine @alexey-ivanov-es
Adding endpoint creation validation for all task types to remaining s…
e59c0a9 
…ervices (elastic#115020) * Adding endpoint creation validation for all task types to remaining services * Update Cohere IT tests for rerank validation * Adding missing import * Update docs/changelog/115020.yaml * Fixing GoogleVertex tests after merge from upstream --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged >enhancement :ml Machine learning Team:ML Meta label for the ML team v8.18.0 v9.0.0

4 participants

@dan-rubinstein @elasticsearchmachine @elasticmachine @davidkyle