[8.x] [Inference API] Introduce Update API to change some aspects of existing inference endpoints (#114457) #114734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ng inference endpoints (elastic#114457) (cherry picked from commit 6b714e2)
maxhniebergall added the auto-merge-without-approval 
added 2 commits October 14, 2024 12:02
…niebergall/backport/8.x/pr-114457
maxhniebergall commented Oct 14, 2024
| if (unvalidatedMap.containsKey(TASK_SETTINGS)) { | ||
| if (unvalidatedMap.get(TASK_SETTINGS) instanceof Map<?, ?> tempMap) { | ||
| for (Map.Entry<?, ?> entry : (tempMap).entrySet()) { | ||
| if (entry.getKey() instanceof String key) { |
There was a problem hiding this comment.
I had to change this line and the similar line above to only use instanceOf on the key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation