Skip to content

Conversation

carlosdelest
Copy link
Member

@carlosdelest carlosdelest commented Oct 10, 2024

Closes #114432
Closes #114443
Closes #114444

Increase timeout in health check for cluster, introduced in #114400.

Health checks on synonyms index is failing with a timeout before it reaches green status. There's no reason for the index not to reach it, and other tests that use cluster health have an increased timeout for cluster health check.

@carlosdelest carlosdelest added :Search Relevance/Analysis How text is split into tokens >test-failure Triaged test failures from CI auto-backport Automatically create backport pull requests when merged Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.16.0 v9.0.0 labels Oct 10, 2024
@carlosdelest carlosdelest requested a review from kingherc October 10, 2024 07:14
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the needs:risk Requires assignment of a risk label (low, medium, blocker) label Oct 10, 2024
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'd recommend not backporting since #114426 failed CI and I just saw you agree it's not needed in 8.16.x, so I'll close that PR.

@carlosdelest carlosdelest removed auto-backport Automatically create backport pull requests when merged v8.16.0 labels Oct 10, 2024
@carlosdelest
Copy link
Member Author

Makes sense @kingherc , this was broken only for main so we can reevaluate if needed 👍

@carlosdelest carlosdelest merged commit 73c69b5 into main Oct 10, 2024
17 checks passed
@carlosdelest carlosdelest deleted the carlosdelest/fix-synonyms-ci-tests-timeout branch October 10, 2024 08:40
matthewabbott pushed a commit to matthewabbott/elasticsearch that referenced this pull request Oct 10, 2024
* Use synonym index alias, add timeout * Unmute tests
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Oct 13, 2024
* Use synonym index alias, add timeout * Unmute tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs:risk Requires assignment of a risk label (low, medium, blocker) :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test-failure Triaged test failures from CI v9.0.0

3 participants