Skip to content

Remove deprecated xpack.searchable.snapshot.allocate_on_rolling_restart setting #114202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 14, 2024
Merged

Remove deprecated xpack.searchable.snapshot.allocate_on_rolling_restart setting #114202

merged 10 commits into from
Nov 14, 2024

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Oct 7, 2024 •
edited
Loading

The setting was created as an escape-hatch in case #66369 had some unintended side-effects. It has been deprecated since #84959 (8.2.0).

We fully rely on the cluster.routing.allocation.enable setting for allocating searchable snapshots as specified in https://www.elastic.co/guide/en/elasticsearch/reference/current/restart-cluster.html#restart-cluster-rolling
@arteam
Remove deprecated `xpack.searchable.snapshot.allocate_on_rolling_rest…
830a6e0 
…art` setting The setting was created as an escape-hatch in case elastic#66369 had some unintended side-effects. It has been deprecated since elastic#84959 (8.2.0).
@arteam arteam added >breaking :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Oct 7, 2024
@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v9.0.0 labels Oct 7, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)
@elasticsearchmachine
Copy link
Collaborator

Hi @arteam, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.
@arteam arteam marked this pull request as draft October 7, 2024 08:23
@arteam arteam added the WIP label Oct 7, 2024
@DaveCTurner
Copy link
Contributor

Hi @arteam this breaking change is now approved, would you get this ready for review?
@arteam
Copy link
Contributor Author

arteam commented Nov 12, 2024

@elasticmachine update branch
@arteam arteam marked this pull request as ready for review November 12, 2024 12:34
@arteam arteam removed the WIP label Nov 12, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Coordination Meta label for Distributed Coordination team label Nov 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination)
@elasticsearchmachine
Copy link
Collaborator

Hi @arteam, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.
@arteam arteam requested a review from DaveCTurner November 12, 2024 15:38
@arteam
Copy link
Contributor Author

arteam commented Nov 14, 2024

Hi @DaveCTurner! Would you able to get a look at the PR?
DaveCTurner
DaveCTurner approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@arteam @DaveCTurner
Update docs/changelog/114202.yaml
86d42c3 
Co-authored-by: David Turner <david.turner@elastic.co>
@arteam
Copy link
Contributor Author

arteam commented Nov 14, 2024

@elasticmachine update branch
@arteam arteam merged commit 1a9302c into elastic:main Nov 14, 2024
16 checks passed
@arteam arteam deleted the remove-allocate-on-rolling-restart branch November 14, 2024 16:34
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this pull request Nov 18, 2024
@arteam @DaveCTurner @salvatore-campagna
Remove deprecated `xpack.searchable.snapshot.allocate_on_rolling_rest…
de103e7 
…art` setting (elastic#114202) The setting was created as an escape-hatch in case elastic#66369 had some unintended side-effects. It has been deprecated since elastic#84959 (8.2.0). --------- Co-authored-by: David Turner <david.turner@elastic.co>
alexey-ivanov-es pushed a commit to alexey-ivanov-es/elasticsearch that referenced this pull request Nov 28, 2024
@arteam @DaveCTurner @alexey-ivanov-es
Remove deprecated `xpack.searchable.snapshot.allocate_on_rolling_rest…
4c1c521 
…art` setting (elastic#114202) The setting was created as an escape-hatch in case elastic#66369 had some unintended side-effects. It has been deprecated since elastic#84959 (8.2.0). --------- Co-authored-by: David Turner <david.turner@elastic.co>
@leemthompo
Copy link
Contributor

@arteam is this PR relevant to the serverless changelog? [FYI this question is based on 9.0 breaking changes]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Coordination Meta label for Distributed Coordination team Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v9.0.0

5 participants

@arteam @elasticsearchmachine @DaveCTurner @leemthompo @elasticmachine