Add more logging to MetricsApmIT to identify why test fails #111360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ldematte added >test 
elasticsearchmachine added Team:Core/Infra 
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
ldematte changed the title 
mark-vieira approved these changes Jul 29, 2024
not-napoleon added a commit that referenced this pull request Jul 25, 2025
This PR reduces the logging level of the test logging added in #111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Jul 25, 2025
This PR reduces the logging level of the test logging added in elastic#111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Jul 25, 2025
This PR reduces the logging level of the test logging added in elastic#111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Jul 25, 2025
This PR reduces the logging level of the test logging added in elastic#111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
not-napoleon added a commit to not-napoleon/elasticsearch that referenced this pull request Jul 25, 2025
This PR reduces the logging level of the test logging added in elastic#111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
elasticsearchmachine pushed a commit that referenced this pull request Jul 25, 2025
This PR reduces the logging level of the test logging added in #111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
elasticsearchmachine pushed a commit that referenced this pull request Jul 25, 2025
This PR reduces the logging level of the test logging added in #111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
elasticsearchmachine pushed a commit that referenced this pull request Jul 25, 2025
This PR reduces the logging level of the test logging added in #111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
elasticsearchmachine pushed a commit that referenced this pull request Aug 14, 2025
This PR reduces the logging level of the test logging added in #111360 to Trace. The issue that logging was intended to investigate has been closed, and there doesn't appear to be any current need for this logging. If we need it in the future, it will be trivial to re-enable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Inspection of logs of failures for #103286 reveal that these tests should have not failed: the APM records contain the metric we should have matched, and the tests are failing for no reason. Adding more logging to see why and where matching is failing (string compare? number parsing?)