Update data streams implicit timestamp ignore_malformed settings (#96051)

In order to avoid failing to create the data stream when the mappings are merged, this PR updates the implicit @timestamp field to set ignore_malformed=false in case it is configured true at the index-wide setting.

Author: jbaiera

docs/changelog/96051.yaml

@@ -0,0 +1,5 @@
+pr: 96051
+summary: Update data streams implicit timestamp `ignore_malformed` settings
+area: Data streams
+type: enhancement
+issues: []

server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java

@@ -91,7 +91,9 @@ public class MetadataIndexTemplateService {
  static {
  final Map<String, Map<String, String>> defaultTimestampField = Map.of(
  DEFAULT_TIMESTAMP_FIELD,
- Map.of("type", DateFieldMapper.CONTENT_TYPE)
+ // We inject ignore_malformed false so that if a user does not add the timestamp field it will explicitly skip applying any
+ // other ignore_malformed configurations from the index settings.
+ Map.of("type", DateFieldMapper.CONTENT_TYPE, "ignore_malformed", "false")
  );
  try {
  DEFAULT_TIMESTAMP_MAPPING = new CompressedXContent(

server/src/main/java/org/elasticsearch/index/IndexMode.java

@@ -225,6 +225,7 @@ protected static String tsdbMode() {
  .startObject("properties")
  .startObject(DataStreamTimestampFieldMapper.DEFAULT_PATH)
  .field("type", DateFieldMapper.CONTENT_TYPE)
+ .field("ignore_malformed", "false")
  .endObject()
  .endObject()
  .endObject())

server/src/test/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateServiceTests.java

@@ -1246,7 +1246,12 @@ public void testDefinedTimestampMappingIsAddedForDataStreamTemplates() throws Ex
 
  assertThat(
  parsedMappings.get(0),
- equalTo(Map.of("_doc", Map.of("properties", Map.of(DEFAULT_TIMESTAMP_FIELD, Map.of("type", "date")))))
+ equalTo(
+ Map.of(
+ "_doc",
+ Map.of("properties", Map.of(DEFAULT_TIMESTAMP_FIELD, Map.of("type", "date", "ignore_malformed", "false")))
+ )
+ )
  );
  assertThat(parsedMappings.get(1), equalTo(Map.of("_doc", Map.of("properties", Map.of("field1", Map.of("type", "keyword"))))));
  assertThat(parsedMappings.get(2), equalTo(Map.of("_doc", Map.of("properties", Map.of("field2", Map.of("type", "integer"))))));
@@ -1353,7 +1358,12 @@ public void testUserDefinedMappingTakesPrecedenceOverDefault() throws Exception
  }).toList();
  assertThat(
  parsedMappings.get(0),
- equalTo(Map.of("_doc", Map.of("properties", Map.of(DEFAULT_TIMESTAMP_FIELD, Map.of("type", "date")))))
+ equalTo(
+ Map.of(
+ "_doc",
+ Map.of("properties", Map.of(DEFAULT_TIMESTAMP_FIELD, Map.of("type", "date", "ignore_malformed", "false")))
+ )
+ )
  );
  assertThat(
  parsedMappings.get(1),
@@ -1402,7 +1412,12 @@ public void testUserDefinedMappingTakesPrecedenceOverDefault() throws Exception
  }).toList();
  assertThat(
  parsedMappings.get(0),
- equalTo(Map.of("_doc", Map.of("properties", Map.of(DEFAULT_TIMESTAMP_FIELD, Map.of("type", "date")))))
+ equalTo(
+ Map.of(
+ "_doc",
+ Map.of("properties", Map.of(DEFAULT_TIMESTAMP_FIELD, Map.of("type", "date", "ignore_malformed", "false")))
+ )
+ )
  );
  assertThat(
  parsedMappings.get(1),