Update data streams implicit timestamp ignore_malformed settings #96051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…malformed to false
jbaiera added >enhancement :Data Management/Data streams 
| Hi @jbaiera, I've created a changelog YAML for you. |
9 tasks
felixbarny approved these changes May 12, 2023
| Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine added the Team:Data Management 
romseygeek added a commit that referenced this pull request Sep 13, 2023
…ields (#99346) Data-stream mappings require a @timestamp field to be present and configured as a date with a specific set of parameters. The index-wide setting of ignore_malformed can cause problems here if it is set to true, because it needs to be false for the @timestamp field. This commit detects if a set of mappings is configured for a datastream by checking for the presence of a DataStreamTimestampFieldMapper metadata field, and passes that information on during Mapper construction as part of the MapperBuilderContext. DateFieldMapper.Builder now checks to see if it is specifically for a data stream timestamp field, and if it is, sets ignore_malformed to false. Relates to #96051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When data streams are created, they provide a synthetic mapping template that will add an
@timestampfield to the mappings by default if there isn't one already defined. This field on a data stream is incompatible with theignore_malformedparameter which might be settrueat the indexing layer somewhere else on the template.In order to avoid failing to create the data stream when the mappings are merged, this PR updates the implicit
@timestampfield to setignore_malformed=falsein case it is configuredtrueat the index-wide setting.