Add Google Model Garden support for completion and chat_completion tasks #5423
Conversation
Jan-Kazlouski-elastic added the skip-backport 
| Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Thanks! LGTM from a specification perspective. (That is, I didn't check the changes match the Elasticsearch PRs.) Not backporting indeed because:
- part of the change are 9.3 only and
- changing the optionality of
location,model_idandproject_idis breaking for language clients.
Thank you @pquentin . One of the PRs to the elasticsearch is still under review, so this specification update will have to wait a bit till it's merged. |
| /** | ||
| * The name of the location to use for the inference task. | ||
| * The name of the Google Model Garden Provider for `completion` and `chat_completion` tasks. | ||
| * In order for Google Model Garden endpoint to be used `provider` must be defined and be other than `google`. |
There was a problem hiding this comment.
Should this read: In order for a...?
There was a problem hiding this comment.
Yes, you are correct. Fixed
| | ||
| export enum GoogleModelGardenProvider { | ||
| google, | ||
| anthropic, |
There was a problem hiding this comment.
Since we merged anthropic for 9.2 we'll need to release docs for 9.2 that state that only anthropic is supported.
How about we modify this to only include anthropic and then create a new PR that adds the others? That way it'll make it easier to backport the 9.2 anthropic docs.
There was a problem hiding this comment.
Removed all providers except anthropic and google. Could you tell whether or not this PR will have to be backported @jonathan-buttner ?
| /** | ||
| * For a `completion` or `chat_completion` task, allows setting up the `max_tokens` field for request to the Google Model Garden's Anthropic provider. | ||
| * If `max_tokens` is specified - it must be a positive integer. | ||
| */ |
There was a problem hiding this comment.
Can you add an @ext_doc_id link?
There was a problem hiding this comment.
Added a link to anthropic documentation and clarified the comment.
| { | ||
| "service": "googlevertexai", | ||
| "service_settings": { | ||
| "provider": "meta", |
There was a problem hiding this comment.
Just a remind to hold off on adding these until we merge the 9.2 version of the docs.
There was a problem hiding this comment.
Removed the examples with meta provider. Will add them later.
| Hello @jonathan-buttner |
Just to confirm since the initial ES PR that was merged in 9.2 changed optionality of those field does that mean we cannot backport this PR to 9.2? |
This PR adds changes to specification caused by elastic/elasticsearch#134080 and elastic/elasticsearch#135701
Additional actions