- Notifications
You must be signed in to change notification settings - Fork 114
Fix alias examples #5331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alias examples #5331
Conversation
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.19 8.19 # Navigate to the new working tree cd .worktrees/backport-8.19 # Create a new branch git switch --create backport-5331-to-8.19 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 2a84c0ca0dd45f8806158d011748fe2c20b2547c # Push it to GitHub git push --set-upstream origin backport-5331-to-8.19 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.19 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-9.0 9.0 # Navigate to the new working tree cd .worktrees/backport-9.0 # Create a new branch git switch --create backport-5331-to-9.0 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 2a84c0ca0dd45f8806158d011748fe2c20b2547c # Push it to GitHub git push --set-upstream origin backport-5331-to-9.0 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-9.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-9.1 9.1 # Navigate to the new working tree cd .worktrees/backport-9.1 # Create a new branch git switch --create backport-5331-to-9.1 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 2a84c0ca0dd45f8806158d011748fe2c20b2547c # Push it to GitHub git push --set-upstream origin backport-5331-to-9.1 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-9.1 Then, create a pull request where the |
* Fix alias API examples * Generate output * Format yaml (cherry picked from commit 2a84c0c)
* Fix alias API examples * Generate output * Format yaml (cherry picked from commit 2a84c0c)
* Fix alias API examples * Generate output * Format yaml (cherry picked from commit 2a84c0c)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
The create or update alias API (https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-indices-put-alias) contained an example that did not match the specification:
In particular, when I test the
POST /{index}/_aliases/{name}
endpoint locally, it returns aparsing_exception
error for the provided example. I've therefore tested and added examples that align with the https://www.elastic.co/docs/manage-data/data-store/aliases#write-index, https://www.elastic.co/docs/manage-data/data-store/aliases#filter-alias, and https://www.elastic.co/docs/manage-data/data-store/aliases#alias-routing examples