- Notifications
You must be signed in to change notification settings - Fork 115
[DOCS]: Clarify GET / response on Serverless #4981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
| @leemthompo One question: I used the Could you let me know if it’s safe to use? I’d prefer to avoid relying on something that might break later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charlotte-hoblik! Just suggested a rewording for clarity. On the ::: syntax, I have no idea TBH, I think @flobernd probably knows about this. 😄
Co-authored-by: Liam Thompson <leemthompo@gmail.com>
Co-authored-by: Liam Thompson <leemthompo@gmail.com>
| @charlotte-hoblik you'll need to run your make generate commands again to make sure the output files are also updated Would be nice to have screenshots of the examples too for reviewers :) |
specification/_global/info/examples/response/RootNodeInfoResponseExample2.yaml Outdated Show resolved Hide resolved
leemthompo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* Add info about version number for serverless Co-authored-by: Liam Thompson <leemthompo@gmail.com> (cherry picked from commit a81526b)
| The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.17 8.17 # Navigate to the new working tree cd .worktrees/backport-8.17 # Create a new branch git switch --create backport-4981-to-8.17 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 a81526b99d88f1acb13fadf64b9f1d335af72fc2 # Push it to GitHub git push --set-upstream origin backport-4981-to-8.17 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.17Then, create a pull request where the |
* Add info about version number for serverless Co-authored-by: Liam Thompson <leemthompo@gmail.com> (cherry picked from commit a81526b)
* Add info about version number for serverless Co-authored-by: Liam Thompson <leemthompo@gmail.com> (cherry picked from commit a81526b)
* Add info about version number for serverless Co-authored-by: Liam Thompson <leemthompo@gmail.com> (cherry picked from commit a81526b)


This PR:
GET /On Serverless, this endpoint will always return 8.11.0 as the version number and it is expected. Serverless offers automatic upgrades. Version is no longer something the user manages.
Based on: elastic/docs-content#1960