Skip to content

Conversation

@lcawl
Copy link
Contributor

@lcawl lcawl commented Jun 6, 2025

Relates to #4435

This PR adds a link from the get and update cluster settings APIs to https://www.elastic.co/docs/deploy-manage/stack-settings since the full list of settings that can be updated is in the narrative docs rather than the API reference docs.

@lcawl lcawl requested a review from a team June 6, 2025 22:49
@lcawl lcawl marked this pull request as ready for review June 6, 2025 22:49
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cluster.get_settings 🟢 7/7 7/7
cluster.put_settings 🟢 59/59 58/58

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl force-pushed the cluster-settings-overlay branch from 1f6bf42 to 304b073 Compare June 9, 2025 15:54
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cluster.get_settings 🟢 7/7 7/7
cluster.put_settings 🟢 59/59 58/58

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl enabled auto-merge (squash) June 9, 2025 15:57
@lcawl lcawl disabled auto-merge June 9, 2025 15:58
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cluster.get_settings 🟢 7/7 7/7
cluster.put_settings 🟢 59/59 58/58

You can validate these APIs yourself by using the make validate target.

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cluster.get_settings 🟢 7/7 7/7
cluster.put_settings 🟢 59/59 58/58

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 93cbe0b into main Jun 9, 2025
8 checks passed
@lcawl lcawl deleted the cluster-settings-overlay branch June 9, 2025 16:02
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.19 8.19 # Navigate to the new working tree cd .worktrees/backport-8.19 # Create a new branch git switch --create backport-4491-to-8.19 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 93cbe0b3bcd4996a2939c4ffa1dd7553441e32b5 # Push it to GitHub git push --set-upstream origin backport-4491-to-8.19 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-4491-to-8.19.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

The backport to 8.18 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.18 8.18 # Navigate to the new working tree cd .worktrees/backport-8.18 # Create a new branch git switch --create backport-4491-to-8.18 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 93cbe0b3bcd4996a2939c4ffa1dd7553441e32b5 # Push it to GitHub git push --set-upstream origin backport-4491-to-8.18 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.18

Then, create a pull request where the base branch is 8.18 and the compare/head branch is backport-4491-to-8.18.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2025

The backport to 9.0 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-9.0 9.0 # Navigate to the new working tree cd .worktrees/backport-9.0 # Create a new branch git switch --create backport-4491-to-9.0 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 93cbe0b3bcd4996a2939c4ffa1dd7553441e32b5 # Push it to GitHub git push --set-upstream origin backport-4491-to-9.0 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-9.0

Then, create a pull request where the base branch is 9.0 and the compare/head branch is backport-4491-to-9.0.

lcawl added a commit that referenced this pull request Jun 9, 2025
@lcawl
Copy link
Contributor Author

lcawl commented Jun 9, 2025

💚 All backports created successfully

Status Branch Result
9.0

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jun 9, 2025
@lcawl
Copy link
Contributor Author

lcawl commented Jun 9, 2025

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

@lcawl
Copy link
Contributor Author

lcawl commented Jun 9, 2025

💚 All backports created successfully

Status Branch Result
8.18

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jun 9, 2025
lcawl added a commit that referenced this pull request Jun 9, 2025
lcawl added a commit that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment