Skip to content

Conversation

markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Jun 4, 2025

A small PR to remove the stability=experimental tags for the pruning configuration items for the sparse_vector query type.

"stack": {
"since": "8.15.0",
"stability": "experimental"
"since": "8.15.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you automatically regenerate these files, or hand edit them? I think we still need the stack version information and I'm surprised if it got wiped out automatically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the CONTRIBUTING instructions and ran make contrib -- should the since label be updated to 8.19?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, because it's still available in previous APIs? Maybe we can get help from the clients team to confirm this is correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends. If the API did not change since 8.15, then it's fine, otherwise we should switch to 8.19.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Also, sorry for the 2 weeks delay! Asking devtools-team for a review can help with faster review time, as there are many changes here owned by the docs team which we don't review.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends. If the API did not change since 8.15, then it's fine, otherwise we should switch to 8.19.

I think we're good unless there's a change I don't know about (@kderusso ?)

@markjhoy markjhoy marked this pull request as ready for review June 20, 2025 15:51
@markjhoy markjhoy requested review from kderusso and pquentin June 20, 2025 15:51
@markjhoy
Copy link
Contributor Author

NOTE - do not merge until elastic/elasticsearch#128854 is merged

Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@markjhoy markjhoy merged commit a07023b into main Jun 24, 2025
8 checks passed
@markjhoy markjhoy deleted the markjhoy/mark_token_pruning_as_ga branch June 24, 2025 15:36
github-actions bot pushed a commit that referenced this pull request Jun 24, 2025
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit a07023b)
pquentin added a commit that referenced this pull request Jun 26, 2025
(cherry picked from commit a07023b) Co-authored-by: Mark J. Hoy <mark.hoy@elastic.co> Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment