Emit codegen_name for response value bodies #3953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
swallez approved these changes Mar 13, 2025
pquentin approved these changes Mar 18, 2025
| The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.x 8.x # Navigate to the new working tree cd .worktrees/backport-8.x # Create a new branch git switch --create backport-3953-to-8.x # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 331583c54ed24eb2a33f853eec97776e4fdb1590 # Push it to GitHub git push --set-upstream origin backport-3953-to-8.x # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.xThen, create a pull request where the |
| The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.18 8.18 # Navigate to the new working tree cd .worktrees/backport-8.18 # Create a new branch git switch --create backport-3953-to-8.18 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 331583c54ed24eb2a33f853eec97776e4fdb1590 # Push it to GitHub git push --set-upstream origin backport-3953-to-8.18 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.18Then, create a pull request where the |
github-actions bot pushed a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies * Run make contrib --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 331583c)
pquentin pushed a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies * Run make contrib --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 331583c) # Conflicts: # output/schema/schema-serverless.json
pquentin pushed a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies * Run make contrib --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 331583c) # Conflicts: # output/schema/schema-serverless.json
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
pquentin pushed a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies * Run make contrib --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 331583c) Co-authored-by: Florian Bernd <git@flobernd.de>
pquentin added a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies * Run make contrib --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 331583c) # Conflicts: # output/schema/schema-serverless.json Co-authored-by: Florian Bernd <git@flobernd.de>
pquentin added a commit that referenced this pull request Mar 18, 2025
* Emit `codegen_name` for response value bodies * Run make contrib --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit 331583c) # Conflicts: # output/schema/schema-serverless.json Co-authored-by: Florian Bernd <git@flobernd.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As titled.
The
@codegen_nametag for response value bodies was not correctly emitted to theschema.jsonbefore.I took the corresponding code (including the assertion) from the request counterpart. It's debatable wether this should be a hard error or just a validation warning. The assertion is disabled for now, until all places with missing response value body tags are fixed.