Add initial version of schema endpoint generation #3196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Anaethelion requested changes Dec 13, 2024
Contributor
Anaethelion left a comment
Anaethelion left a comment There was a problem hiding this comment.
Overall looks good, could you add some comments on the endpoints.rs file? There's a lot of pattern matching and its not always obvious what each does.
Member Author
| Sorry for the late reply. Assuming you are referring to Anyway, closing this for now as it's now stale with the work on examples. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I'm using a simplified version of the Kibana OpenAPI for one endpoint. Simplifications include:
additionalProperties: {}withadditonalProperties: truemanually. (I initially thought it was a Kibana bug, but the two are in fact equivalent: https://swagger.io/docs/specification/v3_0/data-models/dictionaries/#free-form-objects. I intend to fix this later)AnyOfwhere multiple response are possible.That said, I'm able to generate a schema.json file (that can be used to generate client) from this simplified OpenAPI representation. This is tested using https://insta.rs/.