Skip to content

Java client issues batch 6 #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 31, 2024
Merged

Java client issues batch 6 #2597

merged 4 commits into from
May 31, 2024

Conversation

@l-trotta
Copy link
Contributor

@l-trotta l-trotta commented May 30, 2024 •
edited
Loading

  • 558: box_plot should be boxplot. docs
  • 785: doc_count_error should be doc_count_error_upper_bound. server code (it's the only match when searching)
  • 716, 783: multi term vector can take both _id or doc, with doc being an artificial document which has not been indexed. server code, docs
  • 707: some optional types around NodeInfo and subclasses, to make the nodes.info() endpoint work.
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
mtermvectors 🔴 9/10 9/10
nodes.info 🔴 119/120 0/120

You can validate these APIs yourself by using the make validate target.
@l-trotta l-trotta changed the title box_plot is actually boxplot Java client issues batch 6 May 31, 2024
@l-trotta l-trotta requested a review from flobernd May 31, 2024 13:15
flobernd
flobernd approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@l-trotta l-trotta merged commit 6fdb2c2 into main May 31, 2024
@l-trotta l-trotta deleted the boxplot-fix branch May 31, 2024 13:55
github-actions bot pushed a commit that referenced this pull request May 31, 2024
@l-trotta @github-actions
Java client issues batch 6 (#2597)
0388dd7 
* box_plot is actually boxplot * doc_count_error should be doc_count_error_upper_bound * mtermvector operation id optional * making the nodes (info) endpoint work (cherry picked from commit 6fdb2c2)
@github-actions github-actions bot mentioned this pull request May 31, 2024
Merged
l-trotta added a commit that referenced this pull request May 31, 2024
@github-actions @l-trotta
Java client issues batch 6 (#2597) (#2598)
2a4afb9 
* box_plot is actually boxplot * doc_count_error should be doc_count_error_upper_bound * mtermvector operation id optional * making the nodes (info) endpoint work (cherry picked from commit 6fdb2c2) Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
@l-trotta l-trotta mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 8.14 specification

3 participants

@l-trotta @flobernd