Add downsampling spec for data stream lifecycle #2256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @elastic/clients-team this build is failing with Can someone please advise? |
JoshMock requested changes Aug 29, 2023
Member
JoshMock left a comment
JoshMock left a comment There was a problem hiding this comment.
Not sure what that build error is about, but fixing this typo will rerun the job anyway. 🙂
specification/indices/put_data_lifecycle/IndicesPutDataLifecycleRequest.ts Outdated Show resolved Hide resolved
Contributor Author
| Thanks @JoshMock Seems like the build is happy now |
gmarouli approved these changes Aug 30, 2023
Contributor
gmarouli left a comment
gmarouli left a comment There was a problem hiding this comment.
LGTM, as discussed offline, we agreed that we should allow the client to nullify the rounds. The user can use the downsampling?: DataStreamLifecycleDownsampling to express a nullification during template composition. Apart from that 🚀
Contributor Author
| Superseeded by #2259 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds the specification for downsampling as part of
the data stream lifecycle.
The
downsamplingconfiguration isnullable(just likedata_retention) and itself can contain anullablelistof downsampling rounds.
Each round consists of an
afterduration/timevalue fieldand the downsample configuration (the
fixed_interval)