- Notifications
You must be signed in to change notification settings - Fork 115
Removed redundant date types #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
swallez left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time represents durations (see the number of timeout, offset and interval fields where it's used) and so cannot replace EpochMillis. That being said, there are also occurrences of Time that seem wrong, e.g. BucketSummary.timestamp.
| Superseded by #1713 |
As titled.
We will verify if we have used the wrong date type in the various properties in a separate PR.