Typescript generator lookupBehavior behavior #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Mpdreamz commented Mar 3, 2021
typescript-generator/index.js Outdated
| function isSpecialInterface (type) { | ||
| if (Array.isArray(type.attachedBehaviors)) { | ||
| // assume types ending with Base are abstract and are not the ones doing the implements | ||
| if (type.name.name.endsWith('Base')) |
Member Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I'd rather be explicit in the input spec rather than rely on implicit naming conventions.
Member Author
There was a problem hiding this comment.
++ aggreed, this should be easier once #164 lands
This ensures the typescript generator traverses the types to find the behavior and removes the assumption the behavior is on the type itself. It also makes sure `RequestBase` and `ResponseBase` make it to the to output as these have the behaviors attached to them. When generating a type because the output is all interfaces this now collects all extends/implements and behaviors not on the skiplist and ensures the generated interfaces extends from all.
Mpdreamz force-pushed the fix/behavior-lookup branch from 8321a80 to 19bdc4c Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This ensures the typescript generator traverses the types to find the
behavior and removes the assumption the behavior is on the type itself.
It also makes sure
RequestBaseandResponseBasemake it to the tooutput as these have the behaviors attached to them.
When generating a type because the output is all interfaces this now
collects all extends/implements and behaviors not on the skiplist and
ensures the generated interfaces extends from all.