Skip to content

Conversation

@sethmlarson
Copy link
Contributor

Closes #1566

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you rebase on master?

@sethmlarson sethmlarson force-pushed the ignore-malformed-index-setting branch from 9563503 to d1f9165 Compare April 12, 2022 18:42
@sethmlarson
Copy link
Contributor Author

Thanks Tomas, I'll merge once we get a passing CI.

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.add_block 🟢 2/2 2/2
indices.analyze 🟢 20/20 20/20
indices.clear_cache 🟢 4/4 4/4
indices.clone 🟢 6/6 6/6
indices.close 🟢 42/42 42/42
indices.create_data_stream 🟢 25/25 25/25
indices.create 🔴 669/679 679/679
indices.data_streams_stats 🟢 4/4 4/4
indices.delete_alias 🟢 15/15 15/15
indices.delete_data_stream 🟢 27/27 27/27
indices.delete_index_template 🟢 1/1 1/1
indices.delete_template 🟢 9/9 9/9
indices.delete 🟢 104/104 104/104
indices.disk_usage 🟢 1/1 1/1
indices.exists_alias 🟢 36/36 36/36
indices.exists_index_template Missing test Missing test
indices.exists_template 🟢 15/15 15/15
indices.exists 🟢 39/39 39/39
indices.field_usage_stats 🟢 5/5 5/5
indices.flush 🟢 9/9 9/9
indices.forcemerge 🔴 4/4 3/4
indices.get_alias 🔴 80/80 68/80
indices.get_data_stream 🟢 12/12 12/12
indices.get_field_mapping 🔴 15/15 14/15
indices.get_index_template 🔴 16/16 14/16
indices.get_mapping 🔴 74/74 73/74
indices.get_settings 🔴 54/54 47/54
indices.get_template 🟢 30/30 30/30
indices.get 🔴 52/52 48/52
indices.migrate_to_data_stream Missing test Missing test
indices.modify_data_stream Missing test Missing test
indices.open 🟢 17/17 17/17
indices.promote_data_stream Missing test Missing test
indices.put_alias 🟢 54/54 54/54
indices.put_index_template 🔴 36/37 37/37
indices.put_mapping 🔴 70/71 71/71
indices.put_settings 🔴 45/48 48/48
indices.put_template 🔴 39/41 41/41
indices.recovery 🟢 11/11 11/11
indices.refresh 🟢 202/202 202/202
indices.reload_search_analyzers 🟢 2/2 2/2
indices.resolve_index 🟢 5/5 5/5
indices.rollover 🟢 14/14 14/14
indices.segments 🔴 6/6 4/6
indices.shard_stores 🔴 5/5 2/5
indices.shrink 🟢 5/5 5/5
indices.simulate_index_template 🟢 4/4 4/4
indices.simulate_template 🟢 4/4 4/4
indices.split 🟢 4/4 4/4
indices.stats 🟢 82/82 81/81
indices.unfreeze 🟢 1/1 1/1
indices.update_aliases 🟢 22/22 22/22
indices.validate_query 🟢 7/7 7/7

You can validate these APIs yourself by using the make validate target.

@sethmlarson sethmlarson merged commit 4ebae3f into main Apr 12, 2022
@sethmlarson sethmlarson deleted the ignore-malformed-index-setting branch April 12, 2022 18:56
@github-actions
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-7.17 7.17 # Navigate to the new working tree cd .worktrees/backport-7.17 # Create a new branch git switch --create backport-1620-to-7.17 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick --mainline 1 4ebae3fdcb6cd2741e3e0a31db3debc6fa5ee132 # Push it to GitHub git push --set-upstream origin backport-1620-to-7.17 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1620-to-7.17.

@github-actions
Copy link
Contributor

The backport to 8.1 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.1 8.1 # Navigate to the new working tree cd .worktrees/backport-8.1 # Create a new branch git switch --create backport-1620-to-8.1 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick --mainline 1 4ebae3fdcb6cd2741e3e0a31db3debc6fa5ee132 # Push it to GitHub git push --set-upstream origin backport-1620-to-8.1 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.1

Then, create a pull request where the base branch is 8.1 and the compare/head branch is backport-1620-to-8.1.

@github-actions
Copy link
Contributor

The backport to 8.3 failed:

The process '/usr/bin/git' failed with exit code 128 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-8.3 8.3 # Navigate to the new working tree cd .worktrees/backport-8.3 # Create a new branch git switch --create backport-1620-to-8.3 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick --mainline 1 4ebae3fdcb6cd2741e3e0a31db3debc6fa5ee132 # Push it to GitHub git push --set-upstream origin backport-1620-to-8.3 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-8.3

Then, create a pull request where the base branch is 8.3 and the compare/head branch is backport-1620-to-8.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment