Fix msearch_template Response #1178
Conversation
swallez left a comment
swallez left a comment There was a problem hiding this comment.
Looking at the reference material (code + docs), this change seems wrong. What are the recordings that led to it?
| /** @codegen_names result, failure */ | ||
| export type ResponseItem<TDocument> = | ||
| | MultiSearchItem<TDocument> | ||
| | SearchResponse<TDocument> |
There was a problem hiding this comment.
We need MultiSearchItem as multisearch response items have a status field that indicates the result of each search request. This is present in the ES source code and explained in the docs.
| // This should never happen in clients, because we assume we will never send malformed request. | ||
| error: ErrorCause | ||
| status: integer | ||
| status?: integer |
There was a problem hiding this comment.
Status is always present in error responses, including in multisearch responses. See ES code and the docs "an object with error message and corresponding status code will be returned in place of the actual search response".
Keeping error and status required also plays an important role (in the Java client) to disambiguate some non-200 results where ES will return either a valid response or an error depending on the parameters (e.g. delete document that returns 404+error if the index doesn't exist but 404+valid response if the index exist but not the document).
| Closing this in favour of #1320 |
as titled.