including original document in case where an error is not raised but … #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…returned individually
| Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| related issue |
…expected instead of timeout. (elastic#937) The `timeout` parameter in docstring is misleading for following methods in elasticsearch.client.indices.py, renamed this param in query_params decorator and docstring to `request_timeout`: 1. create 2. open 3. close 4. delete 5. put_mapping 6. put_alias 7. update_aliases 8. delete_alias 9. put_template 10. delete_template 11. shrink 12. rollover
* Update cat.py to have correct query params * Add missing api remote_info and missing params * a couple apis have had added query params * Add Split api and add missing query params * Adding processor_grok api * Adding missing apis: * update by query rethrottle * scripts painless execute * scripts painless context * rank eval * delete by query rethrottle * add missing query params * Add missing xpack apis * Update helpers to account for 7.x scroll api
* Added equality check for Connection class * ES: make connection hashable
| jenkins please test this |
…ic#957) * add cloud_id * adding doc strings * update changelog * adding some tests to check for cloud_id * update the read me
* ml client has not method _bulk_body Need to access the _bulk_body method from the client object closes: elastic#959 * update changelog too
| didn't understand you answer |
| Jenkins year this please |
1 similar comment
| Jenkins year this please |
| Jenkins test this please |
| can we merge? |
Pass scroll and scroll_id in the request body instead of as query params in scan
_make_path encodes "/" - so the request looks like: GET /_cluster%2Fstats%2Fnodes/node_id and elastic returns a 405 error.
| Thank you for this PR, this is a good addition but needs tests as it is very important functionality. Ideally the test would also cover corner cases like people passing in data as string. @viglia do you want to take a stab at those tests? |
| @honzakral yes! |
…returned individually
…1/elasticsearch-py into bugfix/include_original_doc
This commit adds the tests for the patch provided with pr elastic#940 which allows to returna document when an error is not raised. Two tests have been added in test_server/test_helpers.py 1. test_return_docs_when_not_raising_errors: test the mentioned patch and passing json docs 2. test_return_docs_when_not_raising_errors_passing_docs_as_strings: like the previous one but passing serialized json docs as strings
| I think I'm going to close this as "out of date", if you'd still like this merged you'd likely have to update in quite a few places for 8.0. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
21 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…returned individually