Add resource type and resource id in TransportError Traceback #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| @fxdgear ? |
| Jenkins test this please |
| @mazzma12 Could you please signt he CLA? Your tests are passing. It just failed cause some python3.3 weirdness (which is ok cause I'm removing this element from the test matrix cause 3.3 is EOL'd) |
| @fxdgear Happy to contribute, even as small it could be. Signed ! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi @fxdgear.
I modified the
TransportErrorExceptionclass for #906 . I changed the str formatting with % into thestr.join()method. I found it more flexible to deal with empty strings and extra commas. Let me know if you think it is a problem (I checked the tests and it passed)