Skip to content

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented May 31, 2024

Overview

This PR adds an ES|QL and Pandas section to the Integrations page. The content is based on this blog published on Search Labs. The examples remain the same, the style of the explanatory text is adjusted slightly to be in line with the documentation style (less conversational).

I also added the index mapping request and the bulk ingest request behind closed collapsible sections, so users don't need to leave the page. @pquentin @marciw if you think it's better to exclude the requests, let me know. We can also add the content as a subpage of the Integrations page if we think it's better.

Preview

Integrations

Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One sentence jumped out at me so just commenting on that one for now.

I like the collapsible sections 👍

Co-authored-by: Marci Windsheimer <333176+marciw@users.noreply.github.com>
@szabosteve szabosteve marked this pull request as ready for review June 3, 2024 07:43
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me.

I'm happy to merge this as is, but given the amout of content is significant, what are your thoughts on using a specific page for this, as was done for OpenTelemetry?

@szabosteve
Copy link
Contributor Author

@pquentin I agree. I moved the content to a subpage under Integrations in my latest commits.

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion you can take or leave as you see fit! :)

szabosteve and others added 2 commits June 4, 2024 16:45
Co-authored-by: marciw <333176+marciw@users.noreply.github.com>
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Again, this looks good to me and can be merged, but is it useful to add a link from integrations to the new page, as is done for OpenTelemetry?

@pquentin pquentin merged commit 41b091f into main Jun 6, 2024
@pquentin pquentin deleted the szabosteve/pandas-esql branch June 6, 2024 11:32
github-actions bot pushed a commit that referenced this pull request Jun 6, 2024
* [DOCS] Adds ES|QL and Pandas section to the Integrations section. * [DOCS] Fixes link. * Apply suggestions from code review Co-authored-by: Marci Windsheimer <333176+marciw@users.noreply.github.com> * [DOCS] Moves ESQL-Pandas content to a new subpage. * Update docs/guide/esql-pandas.asciidoc Co-authored-by: marciw <333176+marciw@users.noreply.github.com> * [DOCS] Addresses feedback. * [DOCS] Adds section to Integrations that links to ES|QL subpage. --------- Co-authored-by: Marci Windsheimer <333176+marciw@users.noreply.github.com> (cherry picked from commit 41b091f)
@pquentin
Copy link
Member

pquentin commented Jun 6, 2024

Thanks for iterating @szabosteve and for the previous help @marciw! This is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment