- Notifications
You must be signed in to change notification settings - Fork 1.2k
[DOCS] Adds ES|QL and Pandas section to the Integrations section #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One sentence jumped out at me so just commenting on that one for now.
I like the collapsible sections 👍
Co-authored-by: Marci Windsheimer <333176+marciw@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good to me.
I'm happy to merge this as is, but given the amout of content is significant, what are your thoughts on using a specific page for this, as was done for OpenTelemetry?
@pquentin I agree. I moved the content to a subpage under Integrations in my latest commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion you can take or leave as you see fit! :)
Co-authored-by: marciw <333176+marciw@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Again, this looks good to me and can be merged, but is it useful to add a link from integrations to the new page, as is done for OpenTelemetry?
* [DOCS] Adds ES|QL and Pandas section to the Integrations section. * [DOCS] Fixes link. * Apply suggestions from code review Co-authored-by: Marci Windsheimer <333176+marciw@users.noreply.github.com> * [DOCS] Moves ESQL-Pandas content to a new subpage. * Update docs/guide/esql-pandas.asciidoc Co-authored-by: marciw <333176+marciw@users.noreply.github.com> * [DOCS] Addresses feedback. * [DOCS] Adds section to Integrations that links to ES|QL subpage. --------- Co-authored-by: Marci Windsheimer <333176+marciw@users.noreply.github.com> (cherry picked from commit 41b091f)
Thanks for iterating @szabosteve and for the previous help @marciw! This is great. |
Overview
This PR adds an
ES|QL and Pandas
section to the Integrations page. The content is based on this blog published on Search Labs. The examples remain the same, the style of the explanatory text is adjusted slightly to be in line with the documentation style (less conversational).I also added the index mapping request and the bulk ingest request behind closed collapsible sections, so users don't need to leave the page. @pquentin @marciw if you think it's better to exclude the requests, let me know. We can also add the content as a subpage of the Integrations page if we think it's better.
Preview
Integrations