add disable_product_check argument to transport classes #1678
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds the option to disable the product check for users who wish to do that (whether for performance reasons or if they are willing to take the risk of using an unsupported product)
It adds a
disable_product_checkargument to the transport class (sync and async)The change is minimal, utilizing the existing
_verified_elasticsearchvariable and adding an additionalFalsestate to it which means that product check is disabled. Because the_ProductChecker.check_productmethod returns an integer, this new state does not interfere with the existing product check (if not disabled)Tests were updated accordingly.