Fix for 7.4 space encoding change #1040
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Ref: #1037
Elastic-py currently encodes spaces in the url as
+
(as opposed to%20
). Elasticsearch in 7.4 no longer decode+
as a space, so this breaks parameters (id's in my test) that have spaces.(Note the bulk API works correctly with ID's with spaces, so indexing is currently also divergent between the bulk and single api)
This PR uses the python quote method instead of quote_plus which is the same except for encoding spaces as
%20
instead of+
.