Skip to content

Conversation

chrisbennight
Copy link
Contributor

Ref: #1037

Elastic-py currently encodes spaces in the url as + (as opposed to %20). Elasticsearch in 7.4 no longer decode + as a space, so this breaks parameters (id's in my test) that have spaces.

(Note the bulk API works correctly with ID's with spaces, so indexing is currently also divergent between the bulk and single api)

This PR uses the python quote method instead of quote_plus which is the same except for encoding spaces as %20 instead of +.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ghost
Copy link

ghost commented Oct 18, 2019

Hi @chrisbennight, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

1 similar comment
@ghost
Copy link

ghost commented Oct 18, 2019

Hi @chrisbennight, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@chrisbennight
Copy link
Contributor Author

chrisbennight commented Oct 24, 2019

CLA is signed, and email address matches now;

@philkra
Copy link
Contributor

philkra commented Oct 30, 2019

jenkins test this please

@honzakral
Copy link
Contributor

Unfortunately this does not work with python 2. @chrisbennight would you have some time to have a look into the Python 2 failures?

Thank you!

@chrisbennight
Copy link
Contributor Author

Mea culpa, oversight on my part; works fine on py2 now (well, py2.7.x anyway, which I think matches the support matrix)

@honzakral honzakral merged commit 8f5c60f into elastic:master Nov 6, 2019
@honzakral
Copy link
Contributor

Thank you for the quick turnaround, @chrisbennight !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants