supporting-blog-content/evaluating-search-relevance-part-1 #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/333 |
elastic-thanos changed the title 
pquentin approved these changes Sep 25, 2024
There was a problem hiding this comment.
Thanks! LGTM.
For what it's worth, we discussed this offline with @elastic-thanos:
- The correct way to refresh bulk calls is to add
refresh="wait_for"to the bulk() call. The existing way was only adding arefreshfield in the documents - That said, doing that will refresh for every single bulk call (by default every 500 docs) and it is more efficient to only do it once at the end, which is already done in this notebook anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove unnecessary argument