Skip to content

Conversation

swallez
Copy link
Member

@swallez swallez commented Aug 2, 2024

ElasticsearchClient and other client classes now implement Closeable, which closes the underlying Transport object.

@swallez swallez added the Category: Enhancement New feature or request label Aug 2, 2024
@swallez swallez requested a review from l-trotta August 2, 2024 12:48
@swallez swallez merged commit 1b972de into main Aug 5, 2024
@swallez swallez deleted the closeable-client branch August 5, 2024 14:53
Copy link

github-actions bot commented Aug 6, 2024

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-7.17 7.17 # Navigate to the new working tree cd .worktrees/backport-7.17 # Create a new branch git switch --create backport-851-to-7.17 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick --mainline 1 1b972dec95236362c9b02962bc1c0bf0d9746967 # Push it to GitHub git push --set-upstream origin backport-851-to-7.17 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-851-to-7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants