Fix field_masking_span to span_field_masking #808
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… SpanQuery Type enum accordingly and also builder classes
…f span_field_masking
| ❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
| closing this in favor of elastic/elasticsearch-specification#2563 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
field_masking_spanhas been deprecated since ES8.0 in favor ofspan_field_masking.Ref: https://github.com/elastic/elasticsearch/pull/74718/filesThis change is not reflected in Java API causing exception in ES >= 8.0:
deprecated fields not supported here but got [field_masking_span] which has been replaced with [span_field_masking]The following PR fix but also refactor
FieldMaskingSpan*classes intoSpanFieldMasking*classes probably causing some API breaks