Refactor RestClientTransport to allow using other http client libraries #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
swallez changed the title This was referenced Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Extract the logic related to high-level API objects (serialization, deserialization, error handling, etc) that exists in
RestClientTransportto a new abstractElasticsearchTransportBaseclass. This class delegates http processing to implementations of a newTransportHttpClientinterface.The goal is to allow additional implementations to be provided, such as one based on the builtin http client in JDK11+, and allow users to easily implement their own when needed. The new
example-transportssub-project contains an example implementation that uses Netty.Note that
ElasticsearchTransportBasedoes not implement multi-node retry and cluster sniffing, which is provided byRestClientand would have to be re-implemented for other http libraries.Fixes #550