Skip to content

Conversation

swallez
Copy link
Member

@swallez swallez commented Feb 13, 2023

PR #474 added a BinaryData class used to pre-serialize documents in bulk requests in order to evaluate their size.

This PR extends the usage of BinaryData to API requests whose body is an application-provided object. These are the create and index ingestion endpoints, in addition to bulk. This allows providing JSON data as a binary blob without incurring the cost of parsing and reserializing with no additional processing.

@swallez swallez merged commit b96dca4 into main Feb 13, 2023
@swallez swallez deleted the improve-binary-data branch February 13, 2023 17:53
@github-actions
Copy link

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1 

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-7.17 7.17 # Navigate to the new working tree cd .worktrees/backport-7.17 # Create a new branch git switch --create backport-508-to-7.17 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick --mainline 1 b96dca4c4f3a7701493f81dca9930843968f722d # Push it to GitHub git push --set-upstream origin backport-508-to-7.17 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-508-to-7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant