Move default value of 'expand__to_dot' to a variable (#499) #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I see no way of replying to you other than mail; I don't see that question in the thread, I hope it's OK. The reason is simple: in the project where I'm using your library, most of the fields have double underscore in their names, so I'd have to pass that argument every time I create a query which is troublesome. This change is bacward-compatible and will make my life easier. Cheers, Dawid 2018-01-09 20:35 GMT+01:00 Slam <notifications@github.com>: … Hi. Can you pls describe the reason behind this change? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#809 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGB_tX8NrhkkBiv3615XvNxft8ku7p39ks5tI7-WgaJpZM4RVTVW> . |
| Yeah. Got it, removed comment in GH as found hypothetical usage for this. Thx for reply. …On 10 January 2018 at 19:42, Dawid Szmidka ***@***.***> wrote: I see no way of replying to you other than mail; I don't see that question in the thread, I hope it's OK. The reason is simple: in the project where I'm using your library, most of the fields have double underscore in their names, so I'd have to pass that argument every time I create a query which is troublesome. This change is bacward-compatible and will make my life easier. Cheers, Dawid 2018-01-09 20:35 GMT+01:00 Slam ***@***.***>: > Hi. > > Can you pls describe the reason behind this change? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#809# issuecomment-356390391>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AGB_ tX8NrhkkBiv3615XvNxft8ku7p39ks5tI7-WgaJpZM4RVTVW> > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#809 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB1meHdLTcELE3B96Q5imBNpYIAKAiSKks5tJPZ6gaJpZM4RVTVW> . |
| @3lnc could you merge it then? :) |
| Nope, I have no such permissions on this repo, we need to wait for @honzakral |
| @honzakral could you merge this PR, please? |
| @TheName merged, hope it helps! |
| @honzakral thank you! :) |
| @honzakral one more question: Is pypi package v2 going to be updated to the newest code version sometime soon? I was hoping so, that's why it was important for me to merge this code change :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Can we please add it to branch 2.x as well?