Skip to content

Conversation

miguelgrinberg
Copy link
Collaborator

Fixes #1928

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Nov 6, 2024
@miguelgrinberg miguelgrinberg merged commit 5511abe into elastic:main Nov 6, 2024
17 of 18 checks passed
@miguelgrinberg miguelgrinberg deleted the optional-with-pipe-syntax branch November 6, 2024 18:40
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
* Support pipe syntax to declare optional fields Fixes #1928 * type ignores for pipe syntax in 3.8/3.9 (cherry picked from commit 5511abe)
@pySilver
Copy link

pySilver commented Nov 7, 2024

Thanks!

miguelgrinberg added a commit that referenced this pull request Nov 7, 2024
* Support pipe syntax to declare optional fields Fixes #1928 * type ignores for pipe syntax in 3.8/3.9 (cherry picked from commit 5511abe) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
miguelgrinberg added a commit to miguelgrinberg/elasticsearch-dsl-py that referenced this pull request Dec 9, 2024
* Support pipe syntax to declare optional fields Fixes elastic#1928 * type ignores for pipe syntax in 3.8/3.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.x Backport to 8.x
3 participants