[Backport 8.x] Autogenerate Query classes #1917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
* Autogenerate Query classes * handle Python reserved keywords such as from * replace long deprecated 'filtered' query from tests * minor code generation updates * more code generation updates * address typing issues * clean up code generation templates * more code generator cleanup * add a unit test using some of the generated classes * no need to "reset" the interface list * use the transport's DEFAULT type * include inherited properties in docstrings and constructors * support legacy FieldValueFactor name for FieldValueFactorScore * Update utils/generator.py Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> * use the identity operator to check for defaults * rename interfaces.py to types.py * leave undocumented classes and attributes with an empty docstring * add unit test for AttrDict with from reserved keyword * add a dependency on the transport library * Update utils/generator.py Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> * list required arguments first in types.py * add server defaults to argument docstrings * remove unnecessary quotes from type hints in types.py * Update utils/templates/types.py.tpl Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> * Update utils/generator.py Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> * Update utils/generator.py Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> * final round of review improvements --------- Co-authored-by: Quentin Pradet <quentin.pradet@gmail.com> (cherry picked from commit bacfc74)
miguelgrinberg approved these changes Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport bacfc74 from #1890.
I'll wait to merge this until we are closer to the 8.16.0 release, just in case we need to make more 8.15.x releases out of this branch between now and then.