Add AttrList.to_list() #1584
Merged
Add AttrList.to_list() #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 💚 CLA has been signed |
| I signed the CLA. Please proceed the review, thanks |
eapermyakov reviewed Sep 29, 2023
elasticsearch_dsl/utils.py Outdated
| self._l_, self._obj_wrapper = state | ||
| | ||
| def to_list(self): | ||
| return [x for x in self.__iter__()] |
There was a problem hiding this comment.
I suggest doing it analogically with AttrDict.
This will get the original value.
def to_list(self): return self._l_ 
miguelgrinberg approved these changes Apr 24, 2024
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
* Add AttrList.to_list() * simplify to_list() implementation * code formatting --------- Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com> (cherry picked from commit b059c0a)
miguelgrinberg added a commit that referenced this pull request Apr 29, 2024
* Add AttrList.to_list() * simplify to_list() implementation * code formatting --------- Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com> (cherry picked from commit b059c0a)
miguelgrinberg pushed a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
AttrDicthasto_dict()butAttrListdoes not haveto_list().AttrListdoes not work for PyDantic as a data type. It's good if anyone can convertAttrListtolisteasily.Thanks,