Skip to content

Avoid trying to adjust dropped events on test results #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Avoid trying to adjust dropped events on test results #384

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60f13f5
Avoid trying to adjust dropped events on test results
jsoriano Jun 21, 2021
87e58f7
Merge branch 'master' into nil-dropped-events
mtojek Jun 21, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/testrunner/runners/pipeline/test_result.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,15 @@ func adjustTestResult(result *testResult, config *testConfig) (*testResult, erro
// Strip dynamic fields from test result
var stripped testResult
for _, event := range result.events {
if event == nil {
stripped.events = append(stripped.events, nil)
continue
}

var m common.MapStr
err := json.Unmarshal(event, &m)
if err != nil {
return nil, errors.Wrap(err, "can't unmarshal event")
return nil, errors.Wrapf(err, "can't unmarshal event: %s", string(event))
}

for key := range config.DynamicFields {
Expand Down