[CI] Refactor script to run integration tests #2768
Conversation
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/483 |
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/484 |
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/485 |
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/487 |
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/489 |
| /test |
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/491 |
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/492 |
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/494 |
| target=${TARGET#"test-check-packages-"} | ||
| package_folder="${target}.${PACKAGE}" |
There was a problem hiding this comment.
Added as part of the package folder the target that it is running.
If it is required to add with-logstash target to be run in parallel steps, there is a package that would be duplicated. system_benchmark is located twice in with-logstash and benchmarks folders.
That makes me think that if we create two packages with the same folder name in the the folders as:
test/packages/parallel/mypackagetest/packages/false_positives/mypackage
Logs from both executions would be uploaded to the same folder:
buildkite/elastic-package/PR-1234-456/insecure-logs/mypackage
Adding the target this would become:
buildkite/elastic-package/PR-1234-456/insecure-logs/parallel.mypackagebuildkite/elastic-package/PR-1234-456/insecure-logs/false-positivies.mypackage
Not added the full target name (test-check-packages-parallel or test-check-packages-false-positives) to be easier to find the files in the UI.
| test serverless |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/495 |
| test serverless |
💚 Build Succeeded
History
cc @mrodm |
| Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/499 |
| test_each_package=false | ||
| case "${TARGET}" in | ||
| "${PARALLEL_TARGET}" | "${FALSE_POSITIVES_TARGET}" | "${LOGSTASH_TARGET}") | ||
| test_each_package=true | ||
| ;; | ||
| esac | ||
| if [[ "${test_each_package}" == "true" ]]; then |
There was a problem hiding this comment.
Simplified this code to call directly make target with the corresponding variables.
This would help to set up a new target to run in parallel their test packages.
| export GO_VERSION | ||
| | ||
| export SERVERLESS=${SERVERLESS:-"false"} | ||
| export UPLOAD_SAFE_LOGS=${UPLOAD_SAFE_LOGS:-"0"} |
There was a problem hiding this comment.
By default, logs are not uploaded to the private bucket.
3 participants
This PR applies a refactor in
.buildkite/scripts/integration_tests.shto simplify how to set a new target to test all the packages in a given folder independently.It also ensures that in Serverless pipeline just is installed the required tools once.
Author's checklist