[system tests] Allow setting an optional prefix for the service TestRunID #2744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Merged
1 task
mrodm changed the title 
mrodm commented Jul 18, 2025
Comment on lines 486 to 491
| | ||
| prefix := "" | ||
| if v, found := os.LookupEnv("ELASTIC_PACKAGE_PREFIX_SERVICE_TEST_RUN_ID"); found && v != "" { | ||
| prefix = v | ||
| } | ||
| svcInfo.Test.RunID = common.CreateTestRunIDWithPrefix(prefix) |
There was a problem hiding this comment.
In case of using the terraform service deployer, a part of updating the RunID used in as terraform variable, the alias used to render the policy templates in tests needs to be set to the same value as the terraform variable. This is needed for instance for aws.ec2_metrics that filters by the some resource name.
mrodm commented Jul 18, 2025
Comment on lines 60 to +62
| func CreateTestRunID() string { | ||
| return fmt.Sprintf("%d", rand.Intn(testRunMaxID-testRunMinID)+testRunMinID) | ||
| return CreateTestRunIDWithPrefix("") | ||
| } |
There was a problem hiding this comment.
This function is used also in other places (e.g. adding a random suffix to policies), those can be kept as they are now.
For instance:
jsoriano approved these changes Jul 18, 2025
💚 Build Succeeded
cc @mrodm |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR allows to customize the Service TestRunID used in system tests to include a prefix string. This prefix is defined via environment variable:
export ELASTIC_PACKAGE_PREFIX_SERVICE_TEST_RUN_ID=1a2bHow to test this PR locally
While the system tests are running you can check the files created by terraform at:
it should countain a prefix of 9 digits (e.g.
file-1a2b21464.log).or via the Discover view in Kibana filtering by
data_stream.dataset : "terraform_local.local", and it should contain alogfield similar to:Author's Checklist