Skip to content

Conversation

@mjwolf
Copy link
Contributor

@mjwolf mjwolf commented Jul 3, 2025

Update the README templates and generator used in new package creation to match the new standardized README structure. The updated template should be better at helping users write the readme for new packages, by explaining what is needed in each section of the template.

This also makes a few other small changes which will make it easier for new users to create and use integration packages. It moves the generated readme to _dev/build/docs, automatically adds a "Do not modify" message to the README generated during build, and adds a default sample-event (which is needed to build the update readme template, since it now includes {{event}}).

mjwolf added 5 commits July 1, 2025 10:31
Update the README templates and generator used in new package creation to match the new standardized README structure. The updated template should be better at helping users write the readme, by explaining what is needed in each section of the template. This also makes a few other small changes which will make it easier for new users to create integration packages. It moves the generated readme to `_dev/build/docs`, adds a "Do not modify" message to the README generated during `build`, and adds a default sample-event (which is needed to build the update readme template).
Rewrite the readme for the test apache package to use the new docs format. NOTE: This format isn't used in the published apache integration.
@mjwolf
Copy link
Contributor Author

mjwolf commented Jul 3, 2025

The new README template in Kibana, with no changes made to it:

mw-dev-e3609a kb canadacentral azure staging elastic cloud_app_integrations_detail_hello-0 0 9_overview

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you modify one of the packages under test/packages to see the expected usage and result?

@mjwolf
Copy link
Contributor Author

mjwolf commented Jul 7, 2025

Could you modify one of the packages under test/packages to see the expected usage and result?

The panw integration has already been published with the README updated to use the new template: https://github.com/elastic/integrations/tree/main/packages/panw/docs

I can also modify one of the test packages in elastic-package, so there's an example of new template here.

@mjwolf
Copy link
Contributor Author

mjwolf commented Jul 9, 2025

I've changed the readme in the test/packages/parallel/apache package to use the new format. This isn't used in the real, published apache integration yet though. I've just added it here so there's an example of the new format in elastic-package.

mjwolf and others added 4 commits July 29, 2025 13:43
* Add comments on adding datastream fields and events to doc template * Generate fields in "apache" test package docs
@kgeller kgeller requested a review from jsoriano August 1, 2025 02:09
@kgeller kgeller requested a review from jsoriano August 1, 2025 14:45
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the new content is much more useful and complete, thanks!

We can leave the refactor of comments/delimiters in templates for a different iteration.

@kgeller kgeller merged commit 0dc46b2 into elastic:main Aug 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants