-
Couldn't load subscription status.
- Fork 128
Update new package README template #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update the README templates and generator used in new package creation to match the new standardized README structure. The updated template should be better at helping users write the readme, by explaining what is needed in each section of the template. This also makes a few other small changes which will make it easier for new users to create integration packages. It moves the generated readme to `_dev/build/docs`, adds a "Do not modify" message to the README generated during `build`, and adds a default sample-event (which is needed to build the update readme template).
Rewrite the readme for the test apache package to use the new docs format. NOTE: This format isn't used in the published apache integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you modify one of the packages under test/packages to see the expected usage and result?
The I can also modify one of the test packages in elastic-package, so there's an example of new template here. |
| I've changed the readme in the |
internal/packages/archetype/_static/package-docs-readme.md.tmpl Outdated Show resolved Hide resolved
* Add comments on adding datastream fields and events to doc template * Generate fields in "apache" test package docs
… all package types
internal/packages/archetype/_static/package-docs-readme.md.tmpl Outdated Show resolved Hide resolved
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the new content is much more useful and complete, thanks!
We can leave the refactor of comments/delimiters in templates for a different iteration.

Update the README templates and generator used in new package creation to match the new standardized README structure. The updated template should be better at helping users write the readme for new packages, by explaining what is needed in each section of the template.
This also makes a few other small changes which will make it easier for new users to create and use integration packages. It moves the generated readme to
_dev/build/docs, automatically adds a "Do not modify" message to the README generated duringbuild, and adds a default sample-event (which is needed to build the update readme template, since it now includes{{event}}).