Skip to content

Conversation

@jsoriano
Copy link
Member

Use the migration APIs to get deprecation warnings for the data stream under test.

Fixes #2342.

@jsoriano jsoriano requested a review from a team January 23, 2025 12:03
@jsoriano jsoriano self-assigned this Jan 23, 2025
@jsoriano
Copy link
Member Author

test integrations

@elastic-vault-github-plugin-prod

Created or updated PR in integrations repository to test this version. Check elastic/integrations#12434

@jsoriano
Copy link
Member Author

Many packages fail if we enable these checks from 8.17.0: https://buildkite.com/elastic/integrations/builds/20850

Configuring source mode in mappings is deprecated and will be removed in future versions. Use [index.mapping.source.mode] index setting instead. 

It looks like an issue in the stack, so probably we should filter out this warning.

@kpollich
Copy link
Member

This should be fixed by elastic/kibana#207133 which will make 8.17.2

@jsoriano
Copy link
Member Author

Tested in 8.18.0-SNAPSHOT and it is effectively fixed: https://buildkite.com/elastic/integrations/builds/20866

So I will filter out 8.17.0 and 8.17.1 from these warnings.

@jsoriano
Copy link
Member Author

I haven't found any test case to add, the only warning I have seen is the one we are going to ignore.
Though as it is now, it would have helped to earlier detect this.

I am opening for review. Let me know if you have an idea about how to produce a deprecation warning with a package.

@jsoriano jsoriano marked this pull request as ready for review January 23, 2025 18:49
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @jsoriano

@jsoriano jsoriano merged commit 92a005c into elastic:main Jan 24, 2025
3 checks passed
@jsoriano jsoriano deleted the check-elasticsearch-deprecation-warnings branch January 24, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants