Don't use default CA file if profile does not exist #2366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jsoriano commented Jan 22, 2025
| caCertFile := profile.Path(CACertificateFile) | ||
| // Use CA file in the profile only if it exists. | ||
| if _, err := os.Stat(caCertFile); err == nil { | ||
| config.CACertFile = caCertFile |
There was a problem hiding this comment.
This is likely never going to happen. This can only happen with data directories created with some very old versions of elastic-package, that didn't have profile config, but had certificates.
It would be probably fine to just don't set the CA cert file, keeping it just in case.
mrodm approved these changes Jan 22, 2025
💚 Build Succeeded
cc @jsoriano |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When using
elastic-packagewith environment variables with a profilewithout a configured stack, avoid using the default CA certificate
file if it neither exists.
Fix #2365