Add options for API key in clients #2317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jsoriano force-pushed the api-key-clients branch from 98a658e to 91f2b2d Compare 
mrodm reviewed Jan 7, 2025
Comment on lines +173 to +176
| // Avoid returning an empty certificate path, fallback to the default path. | ||
| if caCertPath == "" { | ||
| caCertPath = profile.Path(CACertificateFile) | ||
| } |
There was a problem hiding this comment.
In case of Serverless projects that are not required to set the CA certificate path, would this cause errors ?
There was a problem hiding this comment.
It shouldn't, this CA certificate is only additive. Leaving this empty mounts an empty file in the dockerfile.
There was a problem hiding this comment.
Ok 👍
I was wondering if it could affect in case it is used with a Serverless project that was created out of elastic-package. And the user sets the environment variables and it does not set the environment variable related to the CA to run for instance elastic-package install.
There was a problem hiding this comment.
I haven't found regressions in the serverless provider with these changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add support for API keys in clients and shellinit.
This is enough for some initial support of API keys (#1633), but many things can still fail, specially when running tests and so on. More about this in #2298.
Complementary to #2307 and #2309.