Add error check for HTTPJSON template execution failure #2151
Conversation
| test integrations |
| Created or updated PR in integrations repository to test this version. Check elastic/integrations#11370 |
efd6 force-pushed the check_httpjson_template branch 2 times, most recently from 85d4351 to b1b9c24 Compare 
efd6 force-pushed the check_httpjson_template branch from b1b9c24 to 567d18b Compare 
| test integrations |
| }, | ||
| { | ||
| // HTTPJSON template error. | ||
| includes: regexp.MustCompile(`^error processing response: template: :\d+:\d+: executing "" at <`), |
There was a problem hiding this comment.
Would it be possible to have a test case that reproduces this issue?
There was a problem hiding this comment.
We could maybe add a false positives test case.
There was a problem hiding this comment.
The current HTTPJSON false positive case is already hitting this logic.
| Created or updated PR in integrations repository to test this version. Check elastic/integrations#11370 |
| There seems to be still a related failure in elastic/integrations#11370 |
| Expanded the set of unfortunate false positives. This cannot be worked around in the HTTPJSON template. |
| test integrations |
| Created or updated PR in integrations repository to test this version. Check elastic/integrations#11370 |
💚 Build Succeeded
History
|
3 participants
We don't know if this will result in failures in existing integrations, so running test integrations with a view to resolving them if they exist before this is merged.
Sadly, it needs to be relaxed, but it's better than nothing.
ref: elastic/integrations#11361 (comment)